Uploaded image for project: 'Talend Component Kit'
  1. Talend Component Kit
  2. TCOMP-530

Refactor code to get rid of AbstractTopLevelDefinition

Apply templateInsert Lucidchart Diagram
    XMLWordPrintable

Details

    • Work Item
    • Resolution: Won't Fix
    • Minor
    • 0.24.0
    • None
    • None
    • None
    • All
    • GreenHopper Ranking:
      0|i0zsx7:
    • 9223372036854775807
    • Small

    Description

      According to sgandon we have a new class I18nDefinition which was designed for the same purposes as AbstractTopLevelDefinition, but was moved to Daikon project. We need to get rid of old AbstractTopLevelDefinition class in TCOMP and replace its usage with I18nDefinition.

      Ivan:
      Found following issues to solve:

      1. PropertiesImpl implements both: AnyProperty, Properties interfaces. However Properties extends AnyProperty, so Properties is enough
      2. Following classes duplicates getDisplayName() method (i18n version): PropertyPathConnector, AbstractTopLevelDefinition, I18nDefinition, PropertiesImpl, Property, Form
      3. Should PropertyPathConnector be internationalized at all?
      4. Do we need SimpleNamedThing (not internationalized named thing)?
      5. PresentationItem has no i18n (but I think button should have i18n)
      6. DatasetProperties has no abstract class (Seems they may have a class with getDatastoreProperties() methods)
      7. IOProperties has no parent abstract class

      Steps:

      1. Check all inheritors of SimpleNamedThing

      Attachments

        1. Current Design.png
          69 kB
          Ivan Gonchar
        2. OnlyClasses.png
          45 kB
          Ivan Gonchar
        3. OnlyInterfaces.png
          41 kB
          Ivan Gonchar
        4. Proposed Design.png
          85 kB
          Ivan Gonchar

        Activity

          People

            igonchar Ivan Gonchar
            dchmyga Dmytro Chmyga (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: