Uploaded image for project: 'Talend Component Kit'
  1. Talend Component Kit
  2. TCOMP-414

JDBCOutputProperties does not correctly reference the properties of its linked dataset

Apply templateInsert Lucidchart Diagram
    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 0.18.0
    • None
    • None
    • None
    • All
    • Small

    Description

      org.talend.components.jdbc.datastream.JDBCOutputProperties wrongly declares the ReferenceProperties referencing its linked dataset :

      public ReferenceProperties<JDBCDatasetProperties> dataset = new ReferenceProperties<>("dataset", JDBCOutputDefinition.NAME);
      

      The second argument should be the "@definitionName" of the Dataset (JDBCDatasetDefinition.NAME) so there is an inconsistency.

      This inconsistency prevents Daikon to correctly deserialize the properties of the JdbcOutput since ReferenceProperties.resolveReferenceProperties() will fail to find the expected key to resolve the related Dataset properties.

      N.B : it would be helpful to find a global solution to prevent developers to do such mistakes in the code. We (always ?) want the reference key to be the same as the @definitionKey of the referenced entity.

      Attachments

        Activity

          People

            psouvanlasy Prada Souvanlasy
            psouvanlasy Prada Souvanlasy
            Prada Souvanlasy
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: