Uploaded image for project: 'Talend Component Kit'
  1. Talend Component Kit
  2. TCOMP-2766

Regression on SVG validation on connectors with only PNG images

Apply templateInsert Lucidchart Diagram
    XMLWordPrintable

Details

    • All
    • Small

    Description

      Description

      For connectors-se/jira, and connectors-se/splunk, there're some errors when build :

      It is caused by this line in ComponentValidator.java line 192 :

      If we change back to log.error, the build can pass, and the errors just logged like :

      REM: same error log on "jira-family.svg" twice, because there are more than one validator calls ComponentValidator's validateIcon method

      failOnValidateExceptions change to false, still got the same errors when building

      <validation.failOnValidateExceptions>true</validation.failOnValidateExceptions>

      Question

      Do we need to fix this, or will the framework strictly not allow only PNG files from now?

      Attachments

        Issue Links

          Activity

            People

              acatoire Axel Catoire
              yyin Yueyan Yin
              Axel Catoire, Yueyan Yin
              Axel Catoire Axel Catoire
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: