Uploaded image for project: 'Talend Component Kit'
  1. Talend Component Kit
  2. TCOMP-15

Handle OK/Cancel button on advanced properties dialog from Wizard

Apply templateInsert Lucidchart Diagram
    XMLWordPrintable

Details

    • Work Item
    • Resolution: Fixed
    • Minor
    • 0.2.0
    • None
    • None
    • None
    • All
    • Hide

      This was implemented a different way.

      Two methods have been added to the ComponentService:

      ComponentProperties makeFormCancelable(ComponentProperties properties, String formName);
      ComponentProperties commitFormValues(ComponentProperties properties, String formName);

      The first one is called when you display the dialogue to indicate that you don't want the values saved as you set then, the second one is called when OK on the dialog is pressed.

      Also, when you are using a Form to drive the UI, you should now use Form.setValue(String property, Object value) instead of ComponentProperties.setValue(). This will apply to both the wizard and property sheet (which should be the same).

      When you are just working with the ComponentProperties as model objects, continue to use ComponentProperties.setValue().

      Show
      This was implemented a different way. Two methods have been added to the ComponentService: ComponentProperties makeFormCancelable(ComponentProperties properties, String formName); ComponentProperties commitFormValues(ComponentProperties properties, String formName); The first one is called when you display the dialogue to indicate that you don't want the values saved as you set then, the second one is called when OK on the dialog is pressed. Also, when you are using a Form to drive the UI, you should now use Form.setValue(String property, Object value) instead of ComponentProperties.setValue(). This will apply to both the wizard and property sheet (which should be the same). When you are just working with the ComponentProperties as model objects, continue to use ComponentProperties.setValue().
    • GreenHopper Ranking:
      0|i0rba3:
    • 9223372036854775807
    • Small

    Description

      Right now, a dialog is popped up for the advanced properties and they might be setup inside of the dialog. However there is no mechanism to handle the OK/Cancel. We might need a mechanism to save the original values of the properties associated with the dialog (the Form) and then allow them to be restored upon a cancel.

      Attachments

        Activity

          People

            fupton Francis Upton
            fupton Francis Upton
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: