Uploaded image for project: 'Talend DI components'
  1. Talend DI components
  2. TDI-37320

External node can not pass ChangeMetadataCommand correct(tMap)

Apply templateInsert Lucidchart Diagram
    XMLWordPrintable

Details

    • Bug
    • Status: closed
    • Minor
    • Resolution: Can't Fix
    • None
    • 5.5.2, 5.6.2, 6.0.0
    • Components
    • None
    • Hide

      1.import attache job
      2.remove one output column from tmap node and click "ok" button.
      3.Click "yes" on popup propagate change dialog.
      4.will find tMap pass ChangeMetadataCommand on ExternalNodeChangeCommand line:350, but this command take two parameters and they are new one.
      5.So that metadataInputChanged method can not find this change on the class metadataInputChanged line:167

      Show
      1.import attache job 2.remove one output column from tmap node and click "ok" button. 3.Click "yes" on popup propagate change dialog. 4.will find tMap pass ChangeMetadataCommand on ExternalNodeChangeCommand line:350, but this command take two parameters and they are new one. 5.So that metadataInputChanged method can not find this change on the class metadataInputChanged line:167
    • All
    • Hide

      because of releated too many components, don't do the refactoring this time

      Show
      because of releated too many components, don't do the refactoring this time

    Description

      If we change output schema from tMap component will generate new ChangeMetadataCommand to notice other external node this change.
      But this Command contain two same schema between currentOutputMetadata and newOutputMetadata(ExternalNodeChangeCommand line:350).

      So that other external node can not find this change by this command(for example tAdvancedFileOutputXML component).

      Two parameter keep same schema is unuseful so that if we change currentOutputMetadata to be old one and keep newOutputMetadata as before, then we can avoid this issue.

      After that create new external node will not need consider this issue again,just need the new external node implement metadataInputChanged method.

      Attachments

        Issue Links

          Activity

            People

              xqliu liu xinquan
              zshen shen ze
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: