Uploaded image for project: 'Talend Component Kit'
  1. Talend Component Kit
  2. TCOMP-1698

UiSpecService injects a wrong property for suggestions and dynamic_values

Details

    • Bug
    • Status: Done
    • Major
    • Resolution: Fixed
    • None
    • 1.1.20
    • None
    • All
    • Small

    Description

      The PropertiesConverter of the UiSpecService injects a wrong UI parameter to the UiSpec.

      https://github.com/Talend/component-runtime/blob/component-runtime-1.1.15/component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/PropertiesConverter.java#L82

      In the code above, we can see that a property named with the current property path is injected, while it would rather been expected to inject that property with the current property name.

      Current:

      {
        "configuration": {
          "dataprepType": "PADDING",
          "trimConfiguration": {
            "columnToProcess": "",
            "$configuration.trimConfiguration.columnToProcess_name": ""
          }
        }
      }
      

      Expected:

      {
        "configuration": {
          "dataprepType": "PADDING",
          "trimConfiguration": {
            "columnToProcess": "",
            "$columnToProcess_name": ""
          }
        }
      }
      

      This issue prevents a component to be instantiated if this "buggy" property is not filtered on the client side. There is a mechanism which is put in place in order to ignore those UI properties on the component manager side, but this one will only work after the issue above is fixed https://github.com/Talend/component-runtime/blob/component-runtime-1.1.15/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/reflect/ReflectionService.java#L578 (note this line of code, which will only work after the bug is fixed:

      final String nestedName =
                          entry.getKey().substring(prefix.length(), entry.getKey().indexOf('.', prefix.length() + 1));
      

      Attachments

        Activity

          People

            emmanuel_g emmanuel gallois
            rdubois Rémy DUBOIS
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: